Repository navigation
Docker dependabot - #781
Open
mishaschwartz wants to merge 7 commits into
Open
mishaschwartz wants to merge 7 commits into
mishaschwartz wants to merge 7 commits into
Conversation
Zeitsperre
reviewed
Nov 13, 2026
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4596/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : docker-dependabot DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-118.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1143/NOTEBOOK TEST RESULTS |
fmigneault
requested changes
Nov 13, 2026
fmigneault
left a comment
Member
There was a problem hiding this comment.
I'm fine to try it out. Some items to adjust.
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4597/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : docker-dependabot DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1144/NOTEBOOK TEST RESULTS |
mishaschwartz
marked this pull request as ready for review
November 19, 2026 18:05
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4605/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : docker-dependabot DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1154/NOTEBOOK TEST RESULTS |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add dependabot configuration to keep track of docker image dependencies
This allows dependabot to track and update docker images. Dependabot requires a
docker compose file where images are defined in plain text (not environment variables) so
this change also introduces two additional actions to support this requirement:
.github/workflows/create-full-compose-definition.yml.dependabot/docker-compose.ymlwhich contains the docker imagedefinitions for all services in plain text.
default.envfiles..github/workflows/update-docker-dependabot-prs.ymldefault.envfile whenever dependabot creates a PR updating oneof the docker images.
The file at
.dependabot/docker-compose.ymlcan also be manually updated by running thenew script at
birdhouse/scripts/create-docker-compose-files-for-dependabot.sh. This scriptis also used by the
create-full-compose-definition.ymlaction.In order to ensure that these scripts can properly identify and update the relevant docker image
versions, additional restrictions have been put on how docker images can be defined:
Docker images must be defined as an environment variable in the component's
default.envfile. For example:
Or if a component uses the same version to update multiple images, the variable names can
optionally include a suffix. For example:
What matters is that the shared prefix
Xis immediately followed by either_IMAGEor_VERSION.When developing a new component or updating the variables for an existing component, the image
and version definitions must follow this format in order to be automatically updated.
If you wish to exclude this component from automatic updates then add the component path to the
EXCLUDE_COMPONENTS_REvariable defined inbirdhouse/scripts/dependabot-scripts.include.sh.When developing a new component or updating the variables for an existing component, the image and
version definitions must follow this format in order to be automatically updated.
If you wish to exclude a component from automatic updates then add the component path to the
EXCLUDE_COMPONENTS_REvariable defined inbirdhouse/scripts/dependabot-scripts.include.sh.In order to enforce these image format definitions a pre-commit hook has been added that will
ensure that image definitions conform to the format above.
As part of this update the following variables have been updated in order to conform to the format
described above:
WEAVER_MANAGER_IMAGEhas been updated toWEAVER_IMAGE_MANAGERWEAVER_WORKER_IMAGEhas been updated toWEAVER_IMAGE_WORKERIf you are using these variable names in any external scripts or overriding the default values in a
local environment file, please update the variable names.
Changes
Non-breaking changes
Breaking changes
WEAVER_MANAGER_IMAGEhas been updated toWEAVER_IMAGE_MANAGERWEAVER_WORKER_IMAGEhas been updated toWEAVER_IMAGE_WORKERRelated Issue / Discussion
Additional Information
This has been tested as much as possible on a different fork of this repo but there is only so much that can be tested without merging these changes first. For example, I'm pretty sure this will work with the birdhouse-bot keys and permissions but I have no way of testing that on this repo directly before this is merged.
Because of this, it is possible that we may have to merge this and make some follow-up changes to tweak permissions.
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false