Repository navigation
update weaver 6.18.0 and allow skip WPS providers - #783
Open
fmigneault wants to merge 2 commits into
Open
fmigneault wants to merge 2 commits into
fmigneault wants to merge 2 commits into
Conversation
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4607/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : weaver-update-skip DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-91.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1156/NOTEBOOK TEST RESULTS |
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4609/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : weaver-update-skip DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1157/NOTEBOOK TEST RESULTS |
|
|
||
| WEAVER_WPS_PROVIDERS_SKIP="$(echo "${WEAVER_WPS_PROVIDERS_SKIP:-false}" | tr [:lower:] [:upper:])" | ||
| if [ "${WEAVER_WPS_PROVIDERS_SKIP}" = "TRUE" ]; then | ||
| log WARN "${PREFIX}Requested WEAVER_WPS_PROVIDERS_SKIP. Not proceeding with updates." |
Collaborator
There was a problem hiding this comment.
I'd suggest "INFO" instead of "WARN" since "WARN" typically means that the user should be doing something different but setting WEAVER_WPS_PROVIDERS_SKIP=true is a valid thing todo.
Member
Author
There was a problem hiding this comment.
I selected WARN because my use case is that I set it in env.local by default so I don't have to think about providing it on the command line each time, but I also want to make sure it stands out if it is something that should have been needed due to a WPS provider actually changing, so that I don't get confused why things are not working.
In this case, I consider it as "you are actively bypassing intended syncs, so be warned things might break".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update weaver
Changes
Non-breaking changes
Weaver: update from version
6.16.0to6.18.0supported Python versions, but the Docker remains based on Python 3.13.
OPTIONSrequests and better communicates supported content negotiation media-types.Weaver: provide
WEAVER_WPS_PROVIDERS_SKIPoptionAllows skipping the entire
post-docker-compose-upoperations that updates registered WPS providers.This can save a lot of time when they are not expected to have any metdata changes since the processes
themselves are dynamically retrieved anyway.
Breaking changes
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false