Repository navigation
allow compose dir override in postgres update script - #784
fmigneault wants to merge 2 commits into
Conversation
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4608/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : update-postres-compose-dir DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1157/NOTEBOOK TEST RESULTS |
mishaschwartz
left a comment
There was a problem hiding this comment.
I don't really understand what this is solving.
Especially since BIRDHOUSE_EXE is defined relative to COMPOSE_DIR, if you set COMPOSE_DIR to something unexpected then the whole script will fail since it won't be able to find the right script.
Employ the common COMPOSE_DIR approach to allow custom overrides.
What custom overrides? Do you mean to be setting BIRDHOUSE_LOCAL_ENV instead?
|
We override For the common custom override portion, what I meant is that it aligns with how other scripts define the references, eg: birdhouse-deploy/birdhouse/scripts/create-magpie-users Lines 68 to 70 in 5ab8176 This script was skipping over the Obviously, it assumes that if one overrides |
Overview
Improve postgres update.
Changes
Non-breaking changes
COMPOSE_DIRapproach to allow custom overrides.Breaking changes
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false