fix: parse empty strings #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_string_internal, based on nom's escaped_transform only parsed strings with at least one character. I think escaped_transform itself is buggy, but it was faster to special case empty-strings in the biscuit grammar itself.
divarvel
force-pushed
the
parse-empty-strings
branch
from
e6eb3a6
to
22d05bb
Compare
Geal
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_string_internal, based on nom's escaped_transform only parsed strings with at least one character. I think escaped_transform itself is buggy, but it was faster to special case empty-strings in the biscuit grammar itself.