Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .type() unary method #201

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat: add .type() unary method #201

merged 1 commit into from
Oct 24, 2024

Conversation

divarvel
Copy link
Collaborator

@divarvel divarvel commented Dec 28, 2023

Add .type() method and associated tests.

note: there is a bit of a missed opportunity in not having the types part of the default symbol table, but:

  1. modifying the default symbol table is a breaking change
  2. the default symbol table is primarily for saving space on biscuits, while the type strings should mostly be used on authorizers (they can still happen in checks, but see reason 1.)

Copy link

codspeed-hq bot commented May 26, 2024

CodSpeed Performance Report

Merging #201 will not alter performance

Comparing typeof (7c43662) with v5 (5792345)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.68%. Comparing base (5792345) to head (7c43662).
Report is 2 commits behind head on v5.

Files with missing lines Patch % Lines
biscuit-auth/src/datalog/expression.rs 46.15% 7 Missing ⚠️
biscuit-auth/src/token/builder.rs 0.00% 1 Missing ⚠️
biscuit-parser/src/builder.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v5     #201      +/-   ##
==========================================
+ Coverage   68.50%   68.68%   +0.17%     
==========================================
  Files          25       25              
  Lines        5626     5655      +29     
==========================================
+ Hits         3854     3884      +30     
+ Misses       1772     1771       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divarvel divarvel changed the base branch from main to v5 June 8, 2024 16:06
@divarvel divarvel marked this pull request as ready for review June 8, 2024 16:11
@divarvel divarvel force-pushed the typeof branch 2 times, most recently from cf8c39e to 7b075af Compare June 8, 2024 16:15
@divarvel divarvel merged commit 0cc0189 into v5 Oct 24, 2024
7 checks passed
@divarvel divarvel deleted the typeof branch October 24, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants