refactor(capi): Move CAPI generation to its own crate #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
force-pushed
the
capi-crate
branch
from
9b6ffd9
to
372348a
Compare
ptondereau
force-pushed
the
capi-crate
branch
3 times, most recently
from
6c6277e
to
87d4a95
Compare
Geal
requested changes
Oct 23, 2024
CodSpeed Performance ReportMerging #234 will not alter performanceComparing Summary
|
ptondereau
force-pushed
the
capi-crate
branch
2 times, most recently
from
fb5ca0f
to
f951a8e
Compare
ptondereau
commented
Oct 23, 2024
ptondereau
force-pushed
the
capi-crate
branch
from
f951a8e
to
a71b2fb
Compare
ptondereau
commented
Oct 23, 2024
Comment on lines
-72
to
-82
| include = [ | ||
| "Cargo.toml", | ||
| "cbindgen.toml", | ||
| "build.rs", | ||
| "examples/*.rs", | ||
| "LICENSE", | ||
| "README.md", | ||
| "src/*.rs", | ||
| "src/*/*.rs", | ||
| "tests/*.rs" | ||
| ] |
There was a problem hiding this comment.
I didn't backported this, if someone has a clue on what's the purpose of include config
ptondereau
force-pushed
the
capi-crate
branch
from
a71b2fb
to
dbaecbb
Compare
|
@Geal tests green! 🎉 |
ptondereau
force-pushed
the
capi-crate
branch
from
7ee0ac7
to
00dfed0
Compare
…or handling cross-platform `uint64_t` type
Geal
reviewed
Nov 3, 2024
ptondereau
force-pushed
the
capi-crate
branch
from
ca5d65c
to
08f7900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting capi generation into its own crate
Also, I've updated the release workflow to support multiple OS and arch (Linux and MacOS)