prepare_release.sh: add check that DISTRO_VERSION matches the release name#150
Merged
prepare_release.sh: add check that DISTRO_VERSION matches the release name#150
Conversation
We want to do more checks, so move the checkout to a separate call. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
jklare
reviewed
Apr 17, 2025
scripts/prepare_release.sh
Outdated
|
|
||
| distro_version=$(grep '^DISTRO_VERSION' $WORKDIR/poky/meta-bisdn-linux/conf/distro/bisdn-linux.conf) | ||
|
|
||
| # extract value |
There was a problem hiding this comment.
I think it would be good to have a comment here how the string that we are parsing could look like (especially since there are two different declarations for the same variable below).
To avoid mistakes where DISTRO_VERSION has the wrong format, or was forgotten to be updated, add a check that DISTRO_VERSION matches what the new version says. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_distro_version_check
branch
from
7f5b39b to
c173d9d
Compare
jklare
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we managed to do a release that had an invalid version, let's add a check for the release script to check that
DISTRO_VERSIONis set to the version for which we are preparing a release.