-
Notifications
You must be signed in to change notification settings - Fork 348
Add pool.kryptex.com dashboard link for Kryptex Pool users #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxmalysh
wants to merge
1
commit into
bitaxeorg:master
Choose a base branch
from
maxmalysh:add-kryptex-quicklink
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,7 @@ export class QuicklinkService { | |
| { search: 'parasite.wtf', url: `https://parasite.space/user/${user}` }, | ||
| { regex: /^(eu|au)?solo[46]?.ckpool\.org/, url: `https://$1solostats.ckpool.org/users/${user}` }, | ||
| { search: 'atlaspool.io', url: `https://atlaspool.io/dashboard.html?wallet=${user}` }, | ||
| { regex: /^(.+?)(?:-[a-z]{2})?\.kryptex\.network/, url: `https://pool.kryptex.com/$1/miner/stats/${user.replace(/^solo:/, '')}` }, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be changed to something like: |
||
| ]; | ||
|
|
||
| for (const pool of pools) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should just be the btc pool url, osmu is bitcoin-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of our users mine different sha-256 coins. Same for some other pools already present in this list.
Is there a reason to limit dashboard links just to bitcoin? Can we avoid hardcoding BTC there for convenience of those users? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xf0xx0 @WantClue gentle ping on the question above — please let me know if this is possible, as lots of our users have asked about this.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
osmu is bitcoin-only, other sha256 coins aren't officially supported. preferably thatd include the dashboard quicklinks. thanks for the ping btw, github didn't notify me lmao