fix: add default-jre to devcontainer for OpenAPI codegen#1593
fix: add default-jre to devcontainer for OpenAPI codegen#1593jayrmotta wants to merge 4 commits intobitaxeorg:masterfrom
Conversation
OpenAPI code generation requires Java. The firmware build was failing in the Docker container because the JRE was not installed. Adding default-jre to the base image dependencies fixes the build.
|
Should also be added to README.md https://github.com/bitaxeorg/ESP-Miner?tab=readme-ov-file#prerequisites-1 |
|
Alternatively, change to a non-Java based generator? |
I did some research on OpenAPI's website and all the alternatives also rely on Java. The only option that doesn't rely on Java is the Docker one, which internally also depends on Java, and then our Dockerfile would have to install Docker which would then install Java, not sure if that's better, I feel it's worse. I also checked the bash launcher, that's just a shell script wrapping the same Java executable. Some other alternatives like |
I tried to refactor the project to use |
Summary
Adds
default-jreto the devcontainer Dockerfile so OpenAPI code generation can run inside the container.Problem
OpenAPI code generation requires Java. The firmware build was failing in the Docker devcontainer because the JRE was not installed.
Solution
Install
default-jrein the base image dependency list in.devcontainer/Dockerfile.Testing
docker build -t espminer-build .devcontaineridf.py build