fix: reset extranonce2 only if clean_jobs == true#1603
Open
blackmennewstyle wants to merge 3 commits intobitaxeorg:masterfrom
Open
fix: reset extranonce2 only if clean_jobs == true#1603blackmennewstyle wants to merge 3 commits intobitaxeorg:masterfrom
blackmennewstyle wants to merge 3 commits intobitaxeorg:masterfrom
Conversation
This PR improves the extranonce2 reset. It is only performed if clean_jobs == true. The previous code was triggering a cascade of duplicate shares after a varDiff change: - mining.set_difficulty - mining.notify with clean_jobs is set to false The behavior is described here: bitaxeorg#1587 (comment)
blackmennewstyle
changed the title
adammwest
reviewed
Mar 12, 2026
main/tasks/create_jobs_task.c
Outdated
| if (!current_mining_notification->clean_jobs) { | ||
| continue; | ||
| // reset extranonce2 only if clean_jobs == true | ||
| // avoid a cosmic festival of duplicated shares |
Contributor
There was a problem hiding this comment.
// reset extranonce2 only if clean_jobs == true The code already shows this.
I think its better to explain a decision, so the cause of the duplicates that led to this PR
so in the future when you look the code again its obvious.
Author
There was a problem hiding this comment.
So should i close this PR and make a new one?
I changed it, hopefully it is better.
More explicit explanation for future code reviewers/contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the extranonce2 reset.
It is only performed if clean_jobs == true.
The previous code was triggering a cascade of duplicate shares after a varDiff change:
cleanJobset to false #1587 (comment)