-
Notifications
You must be signed in to change notification settings - Fork 50
QML Snapshot Load #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: qt6
Are you sure you want to change the base?
QML Snapshot Load #488
Conversation
26a2e0f
to
5e561ef
Compare
I don't know why CI is able to build, I am failing locally which makes sense because
but your commit is not part of that repo, so I get:
I am still trying to figure out what the "file" protocol message is about but otherwise I sort of expected to see this error in CI as well. ChatGPT suspects that the github "checkout" action may have access to some huge github-wide cache and is somehow able to look up |
The fix for me locally which I think should be part of the PR is: diff --git a/.gitmodules b/.gitmodules
index fabdfe506..03c475675 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,3 @@
[submodule "bitcoin"]
path = bitcoin
- url = https://github.com/bitcoin/bitcoin
+ url = https://github.com/D33r-Gee/bitcoin Then I executed:
This tells git to re-read
|
Thanks for testing @pinheadmz ! As you saw currently updating the upstream portion which will impact code review here. Ultimately, the snapshot processing (path → file & metadata) will be moved there. Once the flow is more solid in that location, I’ll update the code here accordingly by removing the models/snapshotqml files and updating the snapshot info retrieval method. |
- This introduce the UI flow to load a AssumeUTXO snapshot - It modifies the connection settings - Adds a SnapshotLoadSettings file, Icon, and modified progress bar. - Also it adds error page on snapshotloading failure
5e561ef
to
daf644c
Compare
This is an re-opened PR based on #424 and #449. It's an alternate to #485 that uses a different /bitcoin branch instead of a patch.
UTXO Snapshot Loading
Overview
This PR enables loading UTXO snapshots both during and after the initial onboarding process.
What This PR Does
Implementation Details
Core Components Modified
qml/models/nodemodel.cpp
)qml/components/SnapshotLoadSettings.qml
,src/qml/components/ConnectionSettings.qml
)Key Design Decisions
Testing Instructions
Test onboarding flow:
Verify (see screenshots below):
Ubuntu 22.04 Screenshots
Expected Behavior
Success/failure state properly displayed
feedback welcome on the approach and implementation details.