Skip to content

Conversation

@waketraindev
Copy link
Contributor

the startingheight rpc field got deprecated in bitcoin/bitcoin#34197
this pr removes it from peer detail

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 6, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, theStack

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@hebasto
Copy link
Member

hebasto commented Jan 6, 2026

cc @theStack

@waketraindev waketraindev marked this pull request as ready for review January 6, 2026 02:48
@maflcko
Copy link
Contributor

maflcko commented Jan 6, 2026

review lgtm ACK 301d9ee

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial plan was to bundle this with the RPC field removal for v32.0, but doing it now also seems fine - no strong feelings either way.

ACK 301d9ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants