-
Notifications
You must be signed in to change notification settings - Fork 53
Add CLN support #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,034
−103
Merged
Add CLN support #713
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e0def8f
add eclair chart
danvergara 1f44794
add eclair as a dependency
danvergara 6c54c7b
add cln chart
danvergara 80c3211
add improvements to the cln node
danvergara 02609bc
fixes for eclair
danvergara 814793c
checkpoint cln integrated into ln_framework
macgyver13 4df0c33
move certs from cln nodes to simln
macgyver13 4c409fd
adjust cln to start grpc
macgyver13 7831413
enable grpc plugin to respond to remote nodes
macgyver13 9fdd5f8
Add styling to standard out for improved readability
macgyver13 a6fc662
Fix wait for gossip loop
macgyver13 915b70e
Merge branch 'main' into add-ln-nodes
macgyver13 5767109
fix linter findings
macgyver13 ff9d32e
don't setup a ln connection to itself
macgyver13 cda355b
Add ln_mixed node test
macgyver13 f1a8b37
switch from print to logger
macgyver13 6355e85
correct formatting ruff finding
macgyver13 f1d7b39
revert -lnd changes based on comments
macgyver13 10531d5
Remove all dependences on -cln or -lnd name to determine type - use p…
macgyver13 3d846d3
address comments
macgyver13 f5aba7c
remove RPC requirements for CLN - fetch rune via http transfer from pod
macgyver13 4fb0225
Add debug logs to deploy step
macgyver13 7890267
try wait_for_pod_ready
macgyver13 76023bb
remove debug logging
macgyver13 f21bfdd
remove unused test files
macgyver13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Patterns to ignore when building packages. | ||
# This supports shell glob matching, relative path matching, and | ||
# negation (prefixed with !). Only one pattern per line. | ||
.DS_Store | ||
# Common VCS dirs | ||
.git/ | ||
.gitignore | ||
.bzr/ | ||
.bzrignore | ||
.hg/ | ||
.hgignore | ||
.svn/ | ||
# Common backup files | ||
*.swp | ||
*.bak | ||
*.tmp | ||
*.orig | ||
*~ | ||
# Various IDEs | ||
.project | ||
.idea/ | ||
*.tmproj | ||
.vscode/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
apiVersion: v2 | ||
name: cln | ||
description: A Helm chart for CLN | ||
|
||
# A chart can be either an 'application' or a 'library' chart. | ||
# | ||
# Application charts are a collection of templates that can be packaged into versioned archives | ||
# to be deployed. | ||
# | ||
# Library charts provide useful utilities or functions for the chart developer. They're included as | ||
# a dependency of application charts to inject those utilities and functions into the rendering | ||
# pipeline. Library charts do not define any templates and therefore cannot be deployed. | ||
type: application | ||
|
||
# This is the chart version. This version number should be incremented each time you make changes | ||
# to the chart and its templates, including the app version. | ||
# Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
version: 0.1.0 | ||
|
||
# This is the version number of the application being deployed. This version number should be | ||
# incremented each time you make changes to the application. Versions are not expected to | ||
# follow Semantic Versioning. They should reflect the version the application is using. | ||
# It is recommended to use it with quotes. | ||
appVersion: "0.1.0" |
78 changes: 78 additions & 0 deletions
78
resources/charts/bitcoincore/charts/cln/templates/_helpers.tpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
{{/* | ||
Expand the name of the PARENT chart. | ||
*/}} | ||
{{- define "bitcoincore.name" -}} | ||
{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} | ||
{{- end }} | ||
|
||
{{/* | ||
Create a default fully qualified PARENT app name. | ||
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
If release name contains chart name it will be used as a full name. | ||
*/}} | ||
{{- define "bitcoincore.fullname" -}} | ||
{{- if .Values.fullnameOverride }} | ||
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} | ||
{{- else }} | ||
{{- printf "%s" .Release.Name | trunc 63 | trimSuffix "-" }} | ||
{{- end }} | ||
{{- end }} | ||
|
||
|
||
{{/* | ||
Expand the name of the chart. | ||
*/}} | ||
{{- define "cln.name" -}} | ||
{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }}-ln | ||
{{- end }} | ||
|
||
{{/* | ||
Create a default fully qualified app name. | ||
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
If release name contains chart name it will be used as a full name. | ||
*/}} | ||
{{- define "cln.fullname" -}} | ||
{{- if .Values.fullnameOverride }} | ||
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} | ||
{{- else }} | ||
{{- printf "%s" .Release.Name | trunc 63 | trimSuffix "-" }}-ln | ||
{{- end }} | ||
{{- end }} | ||
|
||
{{/* | ||
Create chart name and version as used by the chart label. | ||
*/}} | ||
{{- define "cln.chart" -}} | ||
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }} | ||
{{- end }} | ||
|
||
{{/* | ||
Common labels | ||
*/}} | ||
{{- define "cln.labels" -}} | ||
helm.sh/chart: {{ include "cln.chart" . }} | ||
{{ include "cln.selectorLabels" . }} | ||
{{- if .Chart.AppVersion }} | ||
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
{{- end }} | ||
app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
{{- end }} | ||
|
||
{{/* | ||
Selector labels | ||
*/}} | ||
{{- define "cln.selectorLabels" -}} | ||
app.kubernetes.io/name: {{ include "cln.name" . }} | ||
app.kubernetes.io/instance: {{ .Release.Name }} | ||
{{- end }} | ||
|
||
{{/* | ||
Create the name of the service account to use | ||
*/}} | ||
{{- define "cln.serviceAccountName" -}} | ||
{{- if .Values.serviceAccount.create }} | ||
{{- default (include "cln.fullname" .) .Values.serviceAccount.name }} | ||
{{- else }} | ||
{{- default "default" .Values.serviceAccount.name }} | ||
{{- end }} | ||
{{- end }} |
36 changes: 36 additions & 0 deletions
36
resources/charts/bitcoincore/charts/cln/templates/configmap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: {{ include "cln.fullname" . }} | ||
labels: | ||
{{- include "cln.labels" . | nindent 4 }} | ||
data: | ||
config: | | ||
{{- .Values.baseConfig | nindent 4 }} | ||
{{- .Values.defaultConfig | nindent 4 }} | ||
{{- .Values.config | nindent 4 }} | ||
network={{ .Values.global.chain }} | ||
addr=0.0.0.0:{{ .Values.P2PPort }} | ||
bitcoin-rpcconnect={{ include "bitcoincore.fullname" . }} | ||
bitcoin-rpcport={{ index .Values.global .Values.global.chain "RPCPort" }} | ||
bitcoin-rpcpassword={{ .Values.global.rpcpassword }} | ||
alias={{ include "cln.fullname" . }} | ||
announce-addr=dns:{{ include "cln.fullname" . }}:{{ .Values.P2PPort }} | ||
database-upgrade=true | ||
bitcoin-retry-timeout=600 | ||
grpc-port={{ .Values.RPCPort }} | ||
grpc-host=0.0.0.0 | ||
clnrest-host=0.0.0.0 | ||
clnrest-port=3010 | ||
--- | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: {{ include "cln.fullname" . }}-channels | ||
labels: | ||
channels: "true" | ||
{{- include "cln.labels" . | nindent 4 }} | ||
data: | ||
source: {{ include "cln.fullname" . }} | ||
channels: | | ||
{{ .Values.channels | toJson }} |
100 changes: 100 additions & 0 deletions
100
resources/charts/bitcoincore/charts/cln/templates/pod.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
apiVersion: v1 | ||
kind: Pod | ||
metadata: | ||
name: {{ include "cln.fullname" . }} | ||
labels: | ||
{{- include "cln.labels" . | nindent 4 }} | ||
{{- with .Values.podLabels }} | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
app: {{ include "cln.fullname" . }} | ||
{{- if .Values.collectLogs }} | ||
collect_logs: "true" | ||
{{- end }} | ||
chain: {{ .Values.global.chain }} | ||
annotations: | ||
kubectl.kubernetes.io/default-container: "cln" | ||
spec: | ||
{{- with .Values.imagePullSecrets }} | ||
imagePullSecrets: | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
securityContext: | ||
{{- toYaml .Values.podSecurityContext | nindent 4 }} | ||
containers: | ||
- name: {{ .Chart.Name }} | ||
securityContext: | ||
{{- toYaml .Values.securityContext | nindent 8 }} | ||
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" | ||
imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
ports: | ||
- name: p2p | ||
containerPort: {{ .Values.P2PPort }} | ||
protocol: TCP | ||
- name: rpc | ||
containerPort: {{ .Values.RPCPort }} | ||
protocol: TCP | ||
- name: rest | ||
containerPort: {{ .Values.RestPort }} | ||
protocol: TCP | ||
command: | ||
- /bin/sh | ||
- -c | ||
- | | ||
lightningd --conf=/root/.lightning/config & | ||
sleep 1 | ||
lightning-cli createrune > /working/rune.json | ||
echo "Here is the rune file contents" | ||
cat /working/rune.json | ||
wait | ||
livenessProbe: | ||
{{- toYaml .Values.livenessProbe | nindent 8 }} | ||
readinessProbe: | ||
{{- toYaml .Values.readinessProbe | nindent 8 }} | ||
startupProbe: | ||
{{- toYaml .Values.startupProbe | nindent 8 }} | ||
resources: | ||
{{- toYaml .Values.resources | nindent 8 }} | ||
volumeMounts: | ||
{{- with .Values.volumeMounts }} | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} | ||
- mountPath: /root/.lightning/config | ||
name: config | ||
subPath: config | ||
{{- with .Values.extraContainers }} | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
- name: http-server | ||
image: busybox | ||
command: ["/bin/sh", "-c"] | ||
args: | ||
- | | ||
echo "Starting HTTP server..." | ||
busybox httpd -f -p 8080 -h /working | ||
ports: | ||
- containerPort: 8080 | ||
name: http | ||
volumeMounts: | ||
{{- with .Values.volumeMounts }} | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} | ||
volumes: | ||
{{- with .Values.volumes }} | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
- configMap: | ||
name: {{ include "cln.fullname" . }} | ||
name: config | ||
{{- with .Values.nodeSelector }} | ||
nodeSelector: | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
{{- with .Values.affinity }} | ||
affinity: | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
{{- with .Values.tolerations }} | ||
tolerations: | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} |
24 changes: 24 additions & 0 deletions
24
resources/charts/bitcoincore/charts/cln/templates/service.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
apiVersion: v1 | ||
kind: Service | ||
metadata: | ||
name: {{ include "cln.fullname" . }} | ||
labels: | ||
{{- include "cln.labels" . | nindent 4 }} | ||
app: {{ include "cln.fullname" . }} | ||
spec: | ||
type: {{ .Values.service.type }} | ||
ports: | ||
- port: {{ .Values.P2PPort }} | ||
targetPort: p2p | ||
protocol: TCP | ||
name: p2p | ||
- port: {{ .Values.RPCPort }} | ||
targetPort: rpc | ||
protocol: TCP | ||
name: rpc | ||
- port: {{ .Values.RestPort }} | ||
targetPort: rest | ||
protocol: TCP | ||
name: rest | ||
selector: | ||
{{- include "cln.selectorLabels" . | nindent 4 }} |
15 changes: 15 additions & 0 deletions
15
resources/charts/bitcoincore/charts/cln/templates/servicemonitor.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{{- if .Values.metricsExport }} | ||
apiVersion: monitoring.coreos.com/v1 | ||
kind: ServiceMonitor | ||
metadata: | ||
name: {{ include "cln.fullname" . }} | ||
labels: | ||
app.kubernetes.io/name: cln-metrics | ||
release: prometheus | ||
spec: | ||
endpoints: | ||
- port: prometheus-metrics | ||
selector: | ||
matchLabels: | ||
app: {{ include "cln.fullname" . }} | ||
{{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
# Default values for cln. | ||
# This is a YAML-formatted file. | ||
# Declare variables to be passed into your templates. | ||
namespace: warnet | ||
|
||
image: | ||
repository: elementsproject/lightningd | ||
pullPolicy: IfNotPresent | ||
tag: "v25.02" | ||
|
||
nameOverride: "" | ||
fullnameOverride: "" | ||
|
||
podAnnotations: {} | ||
podLabels: | ||
app: "warnet" | ||
mission: "lightning" | ||
|
||
podSecurityContext: {} | ||
|
||
securityContext: {} | ||
|
||
service: | ||
type: ClusterIP | ||
|
||
P2PPort: 9735 | ||
RPCPort: 9736 | ||
RestPort: 3010 | ||
|
||
ingress: | ||
enabled: false | ||
className: "" | ||
annotations: {} | ||
hosts: | ||
- host: chart-example.local | ||
paths: | ||
- path: / | ||
pathType: ImplementationSpecific | ||
tls: [] | ||
|
||
resources: {} | ||
# We usually recommend not to specify default resources and to leave this as a conscious | ||
# choice for the user. This also increases chances charts run on environments with little | ||
# resources, such as Minikube. If you do want to specify resources, uncomment the following | ||
# lines, adjust them as necessary, and remove the curly braces after 'resources:'. | ||
# limits: | ||
# cpu: 100m | ||
# memory: 128Mi | ||
# requests: | ||
# cpu: 100m | ||
# memory: 128Mi | ||
|
||
livenessProbe: | ||
exec: | ||
command: | ||
- "/bin/sh" | ||
- "-c" | ||
- "lightning-cli getinfo >/dev/null 2>&1" | ||
failureThreshold: 3 | ||
initialDelaySeconds: 5 | ||
periodSeconds: 5 | ||
successThreshold: 1 | ||
timeoutSeconds: 1 | ||
readinessProbe: | ||
failureThreshold: 10 | ||
periodSeconds: 30 | ||
successThreshold: 1 | ||
timeoutSeconds: 60 | ||
exec: | ||
command: | ||
- "/bin/sh" | ||
- "-c" | ||
- "lightning-cli getinfo 2>/dev/null | grep -q 'id' || exit 1" | ||
|
||
# Additional volumes on the output Deployment definition. | ||
volumes: | ||
- name: working | ||
emptyDir: {} | ||
|
||
# Additional volumeMounts on the output Deployment definition. | ||
volumeMounts: | ||
- name: working | ||
mountPath: "/working" | ||
|
||
nodeSelector: {} | ||
|
||
tolerations: [] | ||
|
||
affinity: {} | ||
|
||
baseConfig: | | ||
log-level=info | ||
developer | ||
dev-fast-gossip | ||
bitcoin-rpcuser=user | ||
# bitcoind.rpcpass are set in configmap.yaml | ||
config: "" | ||
|
||
defaultConfig: "" | ||
|
||
channels: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,4 +141,5 @@ loadSnapshot: | |
url: "" | ||
|
||
ln: | ||
lnd: false | ||
lnd: false | ||
cln: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,10 @@ def _rpc(pod_name: str, method: str, params: str = "", namespace: Optional[str] | |
pod = get_pod(pod_name) | ||
namespace = get_default_namespace_or(namespace) | ||
chain = pod.metadata.labels["chain"] | ||
cmd = f"kubectl -n {namespace} exec {pod_name} -- lncli --network {chain} {method} {' '.join(map(str, params))}" | ||
ln_client = "lncli" | ||
if "cln" in pod.metadata.labels["app.kubernetes.io/name"]: | ||
ln_client = "lightning-cli" | ||
cmd = f"kubectl -n {namespace} exec {pod_name} -- {ln_client} --network {chain} {method} {' '.join(map(str, params))}" | ||
return run_command(cmd) | ||
|
||
|
||
|
@@ -46,9 +49,13 @@ def pubkey( | |
print(_pubkey(pod)) | ||
|
||
|
||
def _pubkey(pod: str): | ||
info = _rpc(pod, "getinfo") | ||
return json.loads(info)["identity_pubkey"] | ||
def _pubkey(pod_name: str): | ||
info = _rpc(pod_name, "getinfo") | ||
pod = get_pod(pod_name) | ||
pubkey_key = "identity_pubkey" | ||
if "cln" in pod.metadata.labels["app.kubernetes.io/name"]: | ||
pubkey_key = "id" | ||
Comment on lines
+56
to
+57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this kind of thing is ok for now and probably will be ok for eclair as well -- but its a tad codesmelly. feels like implementation-specific methods should stay in their classes, even as jsut static functions |
||
return json.loads(info)[pubkey_key] | ||
|
||
|
||
@ln.command() | ||
|
@@ -62,10 +69,14 @@ def host( | |
print(_host(pod)) | ||
|
||
|
||
def _host(pod): | ||
info = _rpc(pod, "getinfo") | ||
uris = json.loads(info)["uris"] | ||
if uris and len(uris) >= 0: | ||
return uris[0].split("@")[1] | ||
def _host(pod_name: str): | ||
info = _rpc(pod_name, "getinfo") | ||
pod = get_pod(pod_name) | ||
if "cln" in pod.metadata.labels["app.kubernetes.io/name"]: | ||
return json.loads(info)["alias"] | ||
else: | ||
return "" | ||
uris = json.loads(info)["uris"] | ||
if uris and len(uris) >= 0: | ||
return uris[0].split("@")[1] | ||
else: | ||
return "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.