Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Some small fixes to the TS client #3

Open
niekcandaele wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Some small fixes to the TS client #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeb9f3e
fix: compare instead of assignment
niekcandaele Jun 20, 2021
0745ab3
types: getToken can return null
niekcandaele Jun 20, 2021
90d8224
docs: fix a typo
niekcandaele Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/javascript/src/spv-channels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export class ChannelsClient
* @param token Token string.
* @returns Token details.
*/
async getToken(channel: Channel, token: string): Promise<AccessToken>
async getToken(channel: Channel, token: string): Promise<AccessToken|null>
{
console.debug(`Calling listTokens to ${this.getServiceUrl()} for channel with id ${channel.id} using username ${this._username}`);

Expand All @@ -172,7 +172,7 @@ export class ChannelsClient
if (resp.status != 200)
throw new Error(`Error calling SPV channels API. Invalid status code received: ${resp.status.toString()}`);

if (resp.data.length = 1)
if (resp.data.length === 1)
return resp.data[0];

return null;
Expand Down Expand Up @@ -470,7 +470,7 @@ export class MessagingClient
/**
* Check that notifications are active.
*
* @returns True if notifications wesocket is open.
* @returns True if notifications websocket is open.
*/
public notificationsActive() : boolean
{
Expand Down