feat(bitreq): Add Client::with_auth#78
Merged
ValuedMammal merged 4 commits intoJul 10, 2026
Merged
Conversation
`with_auth` calls `with_auth_timeout` using a default 15 second timeout.
Removed `lock` from pre-push recipe, as `cargo rbmt lock` doesn't need to be called before every push to a remote branch, and doing so may add noise to a diff that otherwise doesn't touch the deps in Cargo.toml. However developers must remember to do `cargo rbmt lock` whenever deliberately changing or updating dependencies in a given commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
Client::with_auth(url, auth)as a convenience constructor for thebitreqclient. Previously, callers were required to supply an explicittimeoutparameter viawith_auth_timeout. The new method defaults to a 15-second timeout (DEFAULT_TIMEOUT) and delegates towith_auth_timeout, so existing code is unaffected.Clean up
tests/testenv.rsdoc comments, and reorder sub-commands of thepre-pushrecipe.Bump the version in Cargo.toml to 0.2.0
Changelog notice
Added
bitreq::Client::with_authconstructor using a default 15-second timeoutChanged
0.2.0