test(core): cover SyncRequest progress and expected txids#2233
Open
haoshengzhen wants to merge 1 commit into
Open
test(core): cover SyncRequest progress and expected txids#2233haoshengzhen wants to merge 1 commit into
haoshengzhen wants to merge 1 commit into
Conversation
Signed-off-by: haoshengzhen <haoshengzhen@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
+ Coverage 78.65% 79.06% +0.40%
==========================================
Files 30 30
Lines 5909 5909
Branches 279 280 +1
==========================================
+ Hits 4648 4672 +24
+ Misses 1185 1160 -25
- Partials 76 77 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds coverage for
SyncRequestbehavior inbdk_core::spk_client.The new tests verify that:
SyncRequestreports progress correctly as scripts, txids, and outpoints are consumed.inspectcallback observes the post-consumption progress for each item.Notes to the reviewers
This is a test-only change. I chose this area because
SyncRequestis public API used by chain clients, but the existingspk_clienttest coverage only checked empty response defaults. Covering progress reporting and expected txid matching helps lock in behavior that client integrations may rely on, without changing the implementation or API surface.Changelog notice
No changelog entry needed; this is test coverage only.
Checklists
All Submissions:
New Features:
Bugfixes: