Skip to content

More API fixes#220

Open
luisschwab wants to merge 6 commits into
bitcoindevkit:masterfrom
luisschwab:more-api-fixes
Open

More API fixes#220
luisschwab wants to merge 6 commits into
bitcoindevkit:masterfrom
luisschwab:more-api-fixes

Conversation

@luisschwab

@luisschwab luisschwab commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Changelog

- Use `bitcoin::Witness` for `Vin::witness`
- Use `bitcoin::Address` for `AddressStats::address`
- Use `Duration` for `{Builder,AsyncClient,BlockingClient}::timeout`
- Use `bitcoin::LockTime` for `EsploraTx::locktime`
- Use `bitcoin::transaction::Version` for `EsploraTx::version`
- Use `bitcoin::Sequence` for `Vin::sequence`

@luisschwab luisschwab self-assigned this Jun 20, 2026
@luisschwab

luisschwab commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

We could also use bitcoin::OutPoint for Vin and Utxo.

@luisschwab luisschwab added the api A breaking API change label Jun 20, 2026
@luisschwab luisschwab marked this pull request as ready for review June 20, 2026 19:29
@luisschwab

luisschwab commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

ping @oleonardolima

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleonardolima oleonardolima Awaiting requested review from oleonardolima oleonardolima is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@luisschwab luisschwab

Labels

api A breaking API change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@luisschwab