Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): add new filters for encoding and decoding base64 strings #210

Merged
merged 17 commits into from
Aug 25, 2024

Conversation

mahadzaryab1
Copy link
Contributor

@mahadzaryab1 mahadzaryab1 commented Aug 16, 2024

Added two new filters: EncodeBase64 and DecodeBase64 for encoding and decoding base64 strings. This PR closes #181.

@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review August 16, 2024 15:35
Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mahadzaryab1 mahadzaryab1 requested a review from bitfield August 16, 2024 19:29
@mahadzaryab1 mahadzaryab1 requested a review from bitfield August 17, 2024 16:53
@mahadzaryab1 mahadzaryab1 requested a review from bitfield August 17, 2024 18:14
Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A very neat job. Are you happy for me to pick this up and make the usual minor tweaks, commas and newlines, and final polish? I plan to roll this up along with your other excellent PRs into the next release.

@mahadzaryab1
Copy link
Contributor Author

@bitfield Thank you so much! And yes absolutely, feel free to pick it up and make any tweaks that are needed.

@bitfield bitfield merged commit 10e8421 into bitfield:master Aug 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Base64 encode and decode methods
2 participants