Bugs, Features for nextTransition (and code organization for the same)

[arikorn]

A number of features related to the nextTransition KEY/DSK/BKGD buttons are either broken or missing, including:

• UpStream Key: on preview, change state for USK on preview bus' is broken (doesn't consider DSK/BKGD status, for example)
• Corresponding "DSK on preview" appears to be missing - Created issue Add DSK on PVW feature #55
• The feedback necessary to manage those functions appears to be only partly implemented (Feedback for "show key in PVW" is missing #45)
• ('Next Transition:Set Transition Key Switch' uses "magic numbers" to set the nextTransition state) - The magic numbers are there because this is a bitfield beeing send to the device, but it does not work, issue gostream: Next Transition:Set Transition Key Switch does not work #57 created
• The state object appears to have duplicate properties, some of which are not updated.
  - nextTransition functionality is spread between two or three modules (downstreamKeyer, upstreamKeyer, and mixEffect) - Created issue nextTransition is spread out over many function #56

I have fixed the upstream-in-pvw button and have implemented the feedback (#45) on my local repo...

Files affected so far:
src/functions/mixEffect/state.ts
src/functions/upstreamKeyer/actions.ts
src/functions/upstreamKeyer/state.ts

[fa1k3n]

this issue should be split into the bug parts and the restructure part

[arikorn]

OK. Tomorrow. Should I close this one and open two more? Just edit in place?

(more bugs I forgot to include:

• 'Next Transition:Set Transition Key Switch', I think is intending to allow multiple selections but is defined as 'dropdown' [need to confirm behavior]
• 'Next Transition:Set Transition Key Switch' may send illegal states (i.e. BKGD off when KEY and DSK are off as well).
  )

[fa1k3n]

we can edit this. I give it a shot

[fa1k3n]

OK. Tomorrow. Should I close this one and open two more? Just edit in place?

(more bugs I forgot to include:

• 'Next Transition:Set Transition Key Switch', I think is intending to allow multiple selections but is defined as 'dropdown' [need to confirm behavior]
• 'Next Transition:Set Transition Key Switch' may send illegal states (i.e. BKGD off when KEY and DSK are off as well).
  )

No i think it is correct with a dropdown, if you want to toggle multiple of the targets then just duplicate the action changing the target . And for your last point, this logic is handled on the device itself, there is no need to add this logic in the companion module. The state, thus the feedbacks, will only be updated by what is reported from the device and illegal state requests will not change anything . But the action does not work so issue #57 is created