Skip to content

[BWS] Environmental variable option for bws.config path #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+32 −6
Open

[BWS] Environmental variable option for bws.config path #4048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c131fa
added environmental variable option to bws.config.js
MicahMaphet Nov 7, 2025
4606446
added BITCORE_CONFIG_PATH BWS_CONFIG_PATH and default cases to bws co…
MicahMaphet Nov 7, 2025
37ede59
kenny's review changes: simplified config search logic
MicahMaphet Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions packages/bitcore-wallet-service/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import fs from 'fs';
import path from 'path';
import _ from 'lodash';
import { logger } from './lib/logger';

const Config = (): any => {
let defaultConfig = {
const defaultConfig = {
basePath: '/bws/api',
disableLogs: false,
port: 3232,
Expand Down Expand Up @@ -476,12 +478,36 @@ const Config = (): any => {
};

// Override default values with bws.config.js' values, if present
const { BITCORE_CONFIG_PATH = '../../', BWS_CONFIG_PATH = '../../' } = process.env;
let bwsConfig;

try {
// eslint-disable-next-line @typescript-eslint/no-require-imports
const bwsConfig = require('../../bws.config');
defaultConfig = _.merge(defaultConfig, bwsConfig);
} catch {
logger.info('bws.config.js not found, using default configuration values');
if (BITCORE_CONFIG_PATH) {
if (fs.existsSync(path.join(BITCORE_CONFIG_PATH, 'bitcore.config.json'))) {
bwsConfig = JSON.parse(fs.readFileSync(path.join(BITCORE_CONFIG_PATH, 'bitcore.config.json'), 'utf8'));
} else if (fs.existsSync(BITCORE_CONFIG_PATH) && BITCORE_CONFIG_PATH.endsWith('.json')) {
bwsConfig = JSON.parse(fs.readFileSync(BITCORE_CONFIG_PATH, 'utf8'));
}
bwsConfig = bwsConfig?.bitcoreWalletService;
}

if (!bwsConfig && BWS_CONFIG_PATH) {
if (fs.existsSync(path.join(BWS_CONFIG_PATH, 'bws.config.js'))) {
// eslint-disable-next-line @typescript-eslint/no-require-imports
bwsConfig = require(path.join(BWS_CONFIG_PATH, 'bws.config.js'));
} else if (fs.existsSync(BWS_CONFIG_PATH) && BWS_CONFIG_PATH.endsWith('.js')) {
// eslint-disable-next-line @typescript-eslint/no-require-imports
bwsConfig = require(BWS_CONFIG_PATH);
}
}

if (!bwsConfig) {
logger.info('No config file found. Using default configuration values');
}

bwsConfig = _.merge(defaultConfig, bwsConfig);
} catch (err) {
throw new Error('Error loading config file:\n' + err.stack);
}

if (process.env.SENDGRID_API_KEY) {
Expand Down