-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: RegisterGRPCGatewayRoutes #270
Conversation
📝 WalkthroughWalkthroughThe changes introduce a new line within the Changes
Sequence Diagram(s)sequenceDiagram
participant App as BitsongApp
participant BasicMgr as BasicManager
participant Router as GRPCGatewayRouter
App->>BasicMgr: Create basic manager from app.mm
BasicMgr->>Router: Register gRPC gateway routes (with clientCtx)
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/app.go (1)
552-556
: LGTM! Consider adding error handling.The addition of registering legacy and gRPC gateway routes for all modules is a good enhancement to the API routing capabilities. However, since
RegisterGRPCGatewayRoutes
can return an error, consider handling it to maintain consistency with error handling patterns in the rest of the codebase.// Register legacy and grpc-gateway routes for all modules. -module.NewBasicManagerFromManager(app.mm, nil).RegisterGRPCGatewayRoutes( - clientCtx, - apiSvr.GRPCGatewayRouter, -) +if err := module.NewBasicManagerFromManager(app.mm, nil).RegisterGRPCGatewayRoutes( + clientCtx, + apiSvr.GRPCGatewayRouter, +); err != nil { + panic(fmt.Errorf("failed to register grpc gateway routes: %w", err)) +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/app.go
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: e2e-tests (e2e-pfm)
- GitHub Check: e2e-tests (e2e-basic)
Summary by CodeRabbit