Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cmake manage the project and modify ucat is used c++ #117

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KangLin
Copy link

@KangLin KangLin commented Dec 20, 2018

  1. use cmake manage the project
  2. add ci to automation build the project
  3. modify ucat is used c++ and libevent
  4. modify ucat to support windows

@KangLin KangLin force-pushed the master branch 5 times, most recently from 27d30fb to 24d8f1a Compare December 21, 2018 02:48
@arvidn
Copy link
Contributor

arvidn commented Dec 26, 2018

I think there are some good parts of this patch, I would suggest splitting it up into smaller PRs, that do one thing each

@KangLin
Copy link
Author

KangLin commented Dec 29, 2018

OK! I am splited smaller PRs.

@KangLin KangLin mentioned this pull request Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants