Skip to content

PM-39510: Feat: Use V1 Set and Reset password models#7100

Merged
david-livefront merged 1 commit into
mainfrom
PM-39510-v1-reset-set-password-models
Jun 25, 2026
Merged

PM-39510: Feat: Use V1 Set and Reset password models#7100
david-livefront merged 1 commit into
mainfrom
PM-39510-v1-reset-set-password-models

Conversation

@david-livefront

@david-livefront david-livefront commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-39510

📔 Objective

This PR updates the Password Set and Reset APIs to use the V1 payloads until the server supports both V1 and V2 encryption.

@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 24, 2026
@david-livefront david-livefront requested a review from a team as a code owner June 24, 2026 19:33
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Jun 24, 2026
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the switch of the Set and Reset password flows from V2 to V1 request payloads in AuthRepositoryImpl, the refactor of ResetPasswordRequestJson into a sealed class with V1/V2 variants, and the accompanying test updates. The new V1 field set matches the existing SetPasswordRequestJson.V1 / ResetPasswordRequestJson.V1 model definitions and KDF property types, and there are no remaining references to the old flat ResetPasswordRequestJson constructor. The keys = null argument in setUpdatedPassword is correct — that path updates an existing key rather than provisioning a new RSA keypair (the JIT path continues to send keys).

Code Review Details

No new findings.

Existing threads:

  • The previously flagged CRITICAL (:app test compilation) is resolved.
  • The open SUGGESTED thread on network/src/test/kotlin/com/bitwarden/network/service/AccountsServiceTest.kt (V2 test naming vs. empty current password) remains and is non-blocking; the PR also adds dedicated null current password tests for both V1 and V2.

@david-livefront david-livefront force-pushed the PM-39510-v1-reset-set-password-models branch from af9dc0a to d462a18 Compare June 24, 2026 20:07
@david-livefront david-livefront force-pushed the PM-39510-v1-reset-set-password-models branch from d462a18 to 7cb1fce Compare June 25, 2026 14:07
@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit e5ee43f Jun 25, 2026
37 checks passed
@david-livefront david-livefront deleted the PM-39510-v1-reset-set-password-models branch June 25, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants