Skip to content

Chore: Simplify reset password APIs#7103

Merged
david-livefront merged 1 commit into
mainfrom
cleanup-api-requests
Jun 26, 2026
Merged

Chore: Simplify reset password APIs#7103
david-livefront merged 1 commit into
mainfrom
cleanup-api-requests

Conversation

@david-livefront

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR simplifies the implementation the Reset Password APIs. There should be no functional changes here.

@david-livefront david-livefront requested a review from a team as a code owner June 25, 2026 16:58
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 25, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt labels Jun 25, 2026
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR replaces the verbose @HTTP(method = ..., hasBody = true) Retrofit annotations on resetTempPassword and resetPassword with the idiomatic @PUT/@POST shorthand in AuthenticatedAccountsApi.kt. Both methods retain their @Body parameter, so the change is semantically equivalent with no functional impact, matching the stated objective. The HTTP import remains in use by deleteAccount, and the new PUT import is correctly added.

Code Review Details

No findings. The refactor is clean and behavior-preserving.

@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit e707dda Jun 26, 2026
24 of 28 checks passed
@david-livefront david-livefront deleted the cleanup-api-requests branch June 26, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants