You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the ResetPassword state to require the user to be unlocked. This is required in order to utilize the SDK appropriately when creating the new password.
Reviewed this bug fix that adds an isVaultUnlocked precondition to the ResetPassword navigation branch in RootNavViewModel. When the vault is locked, navigation now falls through to VaultLocked; once the user unlocks, the flow re-evaluates and routes to ResetPassword, ensuring the SDK has an unlocked context when creating the new password. The accompanying test was updated to reflect the new requirement. I traced the full when block control flow and found no correctness, ordering, or breaking-change concerns.
Code Review Details
No findings. The change is minimal, type-safe (isVaultUnlocked and needsPasswordReset are non-nullable Boolean fields on the active account), and the test update correctly aligns with the new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
david-livefront
added
the
ai-review-vnext
github-actions
Bot
added
app:password-manager
🎟️ Tracking
PM-39599
📔 Objective
This PR updates the
ResetPasswordstate to require the user to be unlocked. This is required in order to utilize the SDK appropriately when creating the new password.