[PM-39564] Fill Assist: Support email field key for email-based login forms#7107
Draft
aj-rosado wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39564
📔 Objective
Fill-assist rules in the forms JSON use
"email"as the field key for sites where users log in with their email address (e.g.{ "email": ["input[type='email']"] }). Previously this key was unrecognised — it fell through toelse -> nullintoAutofillViewForFieldKey, so autofill never triggered for those fields.This PR adds a dedicated
AutofillView.Login.Emailsealed subtype and wires it through the fill pipeline with a validation guard: the email field is only filled when the cipher's stored username contains@. If the username is not an email address the field is skipped, avoiding placing a non-email value into antype="email"input.AutofillView.Login.Emailadded alongsideUsernameandPassword"email"key maps toLogin.EmailintoAutofillViewForFieldKeyFilledDataBuilderImplguardsLogin.Email: skips fill whenusernamedoes not passisValidEmail(useStrictValidation = false)AutofillPartitionExtensions.usernameSaveValueupdated to captureLogin.Emailtext values so saving credentials from email-only forms preserves the typed valuewhenexpressions onAutofillViewupdated (AutofillViewExtensions,AutofillParserImpl.updateWebsiteIfNecessary)