Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17784/PM-17588] Flatpak & Mac Store SSH Agent #13324

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Feb 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17784
https://bitwarden.atlassian.net/browse/PM-17588

📔 Objective

Both mac app store and flatpak sandbox the process list, so the information we get back when inspecting the process for the pid obtained by peercred fails. This should not crash, or stop the ssh agent, but instead return "unknown process".

Further, flatpak does not have access to the home directory and requires a separate path configured that other apps can access without changing any permissions.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 35.20%. Comparing base (ddd9185) to head (ece84f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../desktop/desktop_native/core/src/ssh_agent/unix.rs 0.00% 12 Missing ⚠️
...ore/src/ssh_agent/peercred_unix_listener_stream.rs 0.00% 3 Missing ⚠️
...sktop_native/core/src/ssh_agent/peerinfo/models.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13324   +/-   ##
=======================================
  Coverage   35.20%   35.20%           
=======================================
  Files        3127     3127           
  Lines       92568    92568           
  Branches    16857    16857           
=======================================
  Hits        32590    32590           
  Misses      57521    57521           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Logo
Checkmarx One – Scan Summary & Details858460a3-ddf6-4a63-9738-d7ba7fe90f90

Great job, no security vulnerabilities found in this Pull Request

@quexten quexten linked an issue Feb 9, 2025 that may be closed by this pull request
1 task
@quexten quexten changed the title Km/ssh flatpak Flatpak & Mac Store SSH Agent Feb 9, 2025
@quexten quexten linked an issue Feb 10, 2025 that may be closed by this pull request
1 task
@quexten quexten changed the title Flatpak & Mac Store SSH Agent [PM-17784/PM-17588] Flatpak & Mac Store SSH Agent Feb 11, 2025
@quexten quexten requested a review from coltonhurst February 11, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH Agent doesn't work with Flatpak version SSH-Agent not working on App Store version of Bitwarden
1 participant