Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18152] Unable-to-show-correct-passwords-for-website-with-no-domain #13327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shubham20091999
Copy link

@Shubham20091999 Shubham20091999 commented Feb 10, 2025

๐ŸŽŸ๏ธ Tracking

#13326

๐Ÿ“” Objective

Fixing the Bitwarden browser client issue where it fails to retrieve the correct autofill information when a hostname is mapped to an IP address.
For example,
when opening a website http://athena:8080, getDomain function would return null and no autofill suggestions would show up.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Shubham20091999 Shubham20091999 requested a review from a team as a code owner February 10, 2025 00:18
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-18152
Link: https://bitwarden.atlassian.net/browse/PM-18152

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Unable-to-show-correct-passwords-for-website-with-no-domain [PM-18152] Unable-to-show-correct-passwords-for-website-with-no-domain Feb 10, 2025
@djsmith85 djsmith85 linked an issue Feb 10, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not showing correct autofill suggestions for website with no domain
2 participants