Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16953] fix UI design #13346

Merged

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16953

📔 Objective

Fixes UI to align with the intended design for the bulk restore/revoke dialog

📸 Screenshots

Screenshot 2025-02-10 at 1 33 34 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner February 10, 2025 18:53
@BTreston BTreston requested a review from JimmyVo16 February 10, 2025 18:53
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.21%. Comparing base (2b5c786) to head (c00bf1b).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13346   +/-   ##
=======================================
  Coverage   35.21%   35.21%           
=======================================
  Files        3126     3126           
  Lines       92540    92540           
  Branches    16854    16854           
=======================================
  Hits        32589    32589           
  Misses      57494    57494           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1b1462d7-8725-4869-b1d2-52e872b31d0a

Great job, no security vulnerabilities found in this Pull Request

@BTreston BTreston merged commit b2e9548 into main Feb 12, 2025
46 of 47 checks passed
@BTreston BTreston deleted the ac/pm-16953-Bulk-Restore-Revoke-Dialog-design-discrepancies branch February 12, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants