[CL-524] Ensure story elements do not overflow due to wrapper border #13348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
CL-524
📔 Objective
There were some diffs showing up for the kitchen sink popover story this past week. The diffs showed a very small shift (a couple pixels) in the placement of elements on the story. After some investigation, I noticed that the story had a teensy bit of overflow in its container, which caused the side nav to scroll slightly when scrolling to the bottom of the
main
content. This was due to the border present on the story wrapper. This PR changes thebox-sizing
to account for that border so that stories will not have overflow. This may or may not actually solve the diffs appearing -- my theory is that the popover story specifically had issues with it because theplay
action that opens the popover causes the page to scroll, but this may not fix the scroll consistency. It will, however, help all the stories that take up the full wrapper space to fit better inside those wrapper containers.📸 Screenshots
When viewing these videos, watch the side nav.
Before:
Screen.Recording.2025-02-11.at.9.43.24.AM.mov
After:
Screen.Recording.2025-02-11.at.9.42.53.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes