Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-317][CL-502] Remove Storybook combined Light + Dark theme, Nord theme, and Solarized theme #13360

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Feb 11, 2025

๐ŸŽŸ๏ธ Tracking

CL-317
CL-502

๐Ÿ“” Objective

This PR removes the combined light and dark mode theme from Storybook. It was causing some issues (stories using routers had issues; we've seen some snapshot flakiness that may be related to rendering both themes; etc), so we are moving towards viewing the themes separately. This means Chromatic will only capture snapshots in light theme.

This PR also moves the theme class location to the body, which fixes an issue where some elements (dialogs, popups, menus, etc) that are body-appended were not rendering in the correct theme.

This PR also removes the Nord and Solarized themes from Storybook. These are in the process of being deprecated from the clients, so we don't need to document them / encourage their use in Storybook.

๐Ÿ“ธ Screenshots

Before:

Screenshot 2025-02-11 at 12 47 47โ€ฏPM

before.2.mov

After:

Screenshot 2025-02-11 at 12 48 30โ€ฏPM

after.2.mov

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 35.29%. Comparing base (a038371) to head (6d48b37).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13360      +/-   ##
==========================================
+ Coverage   35.20%   35.29%   +0.08%     
==========================================
  Files        3127     3124       -3     
  Lines       92568    92345     -223     
  Branches    16857    16791      -66     
==========================================
+ Hits        32590    32593       +3     
+ Misses      57521    57295     -226     
  Partials     2457     2457              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ ee7f845e-a6b5-4c3d-922f-d64149c67b29

Great job, no security vulnerabilities found in this Pull Request

@vleague2 vleague2 changed the title [CL-317] Remove Storybook combined Light + Dark theme [CL-317][CL-502] Remove Storybook combined Light + Dark theme, Nord theme, and Solarized theme Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant