[CL-317][CL-502] Remove Storybook combined Light + Dark theme, Nord theme, and Solarized theme #13360
+14
โ69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐๏ธ Tracking
CL-317
CL-502
๐ Objective
This PR removes the combined light and dark mode theme from Storybook. It was causing some issues (stories using routers had issues; we've seen some snapshot flakiness that may be related to rendering both themes; etc), so we are moving towards viewing the themes separately. This means Chromatic will only capture snapshots in light theme.
This PR also moves the theme class location to the
body
, which fixes an issue where some elements (dialogs, popups, menus, etc) that are body-appended were not rendering in the correct theme.This PR also removes the Nord and Solarized themes from Storybook. These are in the process of being deprecated from the clients, so we don't need to document them / encourage their use in Storybook.
๐ธ Screenshots
Before:
before.2.mov
After:
after.2.mov
โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes