Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12681] Enable new Send Add/Edit Dialog on web #13361

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Feb 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12681

📔 Objective

Re-using the new Send Add/Edit form, which was introduced with the browser extension refresh, on the web vault.

Changes

  • Create web-specific new-send-dropdown component - 21ea12e
  • Create web-specifc Send Add/Edit dialog - 85e67e6
  • Use new-send-dropdown and replace old Send Add/Edit with new Add/Edit dialog - 89b4e2c
  • Delete old Send Add/Edit component - b80fc5f
  • Remove unused entries from en/messages.json - d8de1db
  • Add cancel button to close dialog - f75f7bb
    • Added after the screenshots were taken

📸 Screenshots

Before After
image image
image image
image
image image
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested review from a team as code owners February 11, 2025 18:07
@djsmith85 djsmith85 requested a review from coroiu February 11, 2025 18:07
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.76%. Comparing base (65024a1) to head (f75f7bb).

❗ There is a different number of reports uploaded between BASE (65024a1) and HEAD (f75f7bb). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (65024a1) HEAD (f75f7bb)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13361       +/-   ##
===========================================
- Coverage   35.29%   15.76%   -19.53%     
===========================================
  Files        3124       27     -3097     
  Lines       92358     1884    -90474     
  Branches    16794        0    -16794     
===========================================
- Hits        32597      297    -32300     
+ Misses      57304     1587    -55717     
+ Partials     2457        0     -2457     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 changed the title [PM-12681][PM-17501] Enable new Send Add/Edit Dialog on web [PM-12681] Enable new Send Add/Edit Dialog on web Feb 11, 2025
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse7842929-0f59-44e1-8be6-ee3b2c659c25

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving platform changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants