Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opera mv3 build changes #13365

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Opera mv3 build changes #13365

wants to merge 3 commits into from

Conversation

justindbaur
Copy link
Member

@justindbaur justindbaur commented Feb 11, 2025

🎟️ Tracking

📔 Objective

Update workflow to prepare for release of the MV3 version of our browser extension for Opera. We are doing this change for both Opera and Firefox but they are done separately so that we can easily revert this PR if we run into issues during regression with the new version.

Related: #13366

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested a review from a team as a code owner February 11, 2025 21:09
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.28%. Comparing base (e3870a6) to head (6fa0321).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13365   +/-   ##
=======================================
  Coverage   35.28%   35.28%           
=======================================
  Files        3124     3124           
  Lines       92349    92349           
  Branches    16793    16793           
=======================================
  Hits        32586    32586           
  Misses      57306    57306           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Logo
Checkmarx One – Scan Summary & Detailsaeff7ae6-79d1-46e1-bac2-9dccf313bfee

Great job, no security vulnerabilities found in this Pull Request

addisonbeck
addisonbeck previously approved these changes Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants