Skip to content

[BRE-401] Skipping cred retrieval if only self-host changed #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 9, 2025

Conversation

pixman20
Copy link
Contributor

@pixman20 pixman20 commented Apr 7, 2025

🎟️ Tracking

BRE-401

📔 Objective

Skips pulling credentials only needed for sm-operator if those tests do not need to run.
To get the test workflow working, this also updates the test-values.yml file to fix mssql server issues and OOM errors.
The main cluster setup script was moved to a scripts directory for local testing using a kind cluster.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@pixman20 pixman20 requested a review from a team April 7, 2025 17:38
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Logo
Checkmarx One – Scan Summary & Details0ffddfe5-552c-418c-8454-7c594d9dfe87

Great job, no security vulnerabilities found in this Pull Request

@pixman20 pixman20 marked this pull request as draft April 8, 2025 14:40
Copy link

sonarqubecloud bot commented Apr 8, 2025

@pixman20 pixman20 marked this pull request as ready for review April 8, 2025 20:49
Copy link

@AmyLGalles AmyLGalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for walking us through this

@pixman20 pixman20 merged commit 69abbfe into main Apr 9, 2025
9 checks passed
@pixman20 pixman20 deleted the BRE-401-skip-cred-retrieval-self-host branch April 9, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants