Auth/PM-22661 - Send Access #351
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el + send access token struct
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 76.10% 76.73% +0.63%
==========================================
Files 264 268 +4
Lines 24045 24903 +858
==========================================
+ Hits 18299 19109 +810
- Misses 5746 5794 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… locations to be more idiomatic and logical
…flat structures and test utilities wiremock and zeroize.
…ng C dynamic lib, build a normal rust lib (rlib) for this crate since a C dynamic lib can't be used to run E2E tests.
…ion tests can only access the public API
…d request and grant errors
…n have output codes instead of sentences but we can still deserialize error descriptions from server.
…h optional error desc so we can make it truly optional in typescript
…and test everything.
…perly handle all known identity server responses + integrate our new, custom send_access_error_type enum for better handling instead of depending on a brittle, freeform error desc.
…pi_error_response changes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22661
📔 Objective
To build out the SDK portion of the new
Auth/SendAccessfeature which serves outSendAccessTokensfor successful authN requests.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes