[PM-24263] Pin protected key envelope unlock #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal into km/cose-content-format
Hinton
reviewed
Aug 22, 2025
| let mut ctx = key_store.context_mut(); | ||
|
|
||
| let key_envelope = | ||
| PasswordProtectedKeyEnvelope(bitwarden_crypto::safe::PasswordProtectedKeyEnvelope::seal( |
There was a problem hiding this comment.
suggestion: We already import PasswordProtectedKeyEnvelope, use the short path.
Suggested change
| PasswordProtectedKeyEnvelope(bitwarden_crypto::safe::PasswordProtectedKeyEnvelope::seal( | |
| PasswordProtectedKeyEnvelope(PasswordProtectedKeyEnvelope::seal( |
There was a problem hiding this comment.
Ah, my bad I should have not merged this. The imported PasswordProtectedKeyEnvelope is the non-generic wrapper. The contained envelope that uses the long path is the generic struct from crypto. So they are different structs.
Maybe they should have different naming after all..
I've undone the merge now.
Co-authored-by: Oscar Hinton <[email protected]>
Hinton
previously approved these changes
Aug 22, 2025
This reverts commit e30b8b0.
Hinton
previously approved these changes
Aug 25, 2025
quexten
requested review from
mzieniukbw,
coroiu and
dani-garcia
and removed request for
coroiu
dani-garcia
previously approved these changes
Aug 25, 2025
|
Had to resolve some conflicts from the |
|
dani-garcia
approved these changes
Aug 26, 2025
|
Merging since there was no significant change since the last set of reviews, so 1 review seems enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24263
📔 Objective
Adds enrollment functionality for Password(PIN)Protected user key envelope. Both crypto initialization via the init request, and a function exposing the raw key material are provided. The latter is required since unlock is not yet done via the init methods on WASM/
clients.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes