Preserve original encrypted OpenSSH/PKCS#8 PEM on import + on-demand decryption for SSH agent #408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes loss of encryption headers when importing SSH private keys by preserving the exact original PEM (including bcrypt/aes header) and introducing a just-in-time decrypt function for SSH agent operations. It also plumbs new metadata through SshKeyView for clients to enable improved UX.
Linked PRs needed to work for this changes:
Linked Issue
Root Cause
Imported SSH keys were always re-encoded into unencrypted OpenSSH format (via to_openssh), stripping encrypted headers. Copying/using the key later did not match the original encrypted PEM.
Approach
Changes
Backwards Compatibility
Security Considerations
Testing