Skip to content

[PM-20586] - Fixing allowing seats to increase to limit #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Apr 24, 2025

🎟️ Tracking

PM-20586

📔 Objective

This adds a new property to signify when the max seats have been exceeded to mark the request as invalid.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested a review from a team as a code owner April 24, 2025 19:50
@jrmccannon jrmccannon requested a review from r-tome April 24, 2025 19:50
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc1e815c5-32a7-46d8-b89c-ac2c3f4932ab

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.20%. Comparing base (8a2012b) to head (dc0a5ed).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...sswordManager/PasswordManagerSubscriptionUpdate.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5705      +/-   ##
==========================================
- Coverage   50.43%   47.20%   -3.24%     
==========================================
  Files        1633     1633              
  Lines       74162    74163       +1     
  Branches     6675     6676       +1     
==========================================
- Hits        37407    35009    -2398     
- Misses      35243    37703    +2460     
+ Partials     1512     1451      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrmccannon jrmccannon merged commit 12fc9df into main Apr 28, 2025
53 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-20586 branch April 28, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants