Skip to content

chore/SRE-583 Deprecate usage of Auth-Email Header #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bitwarden-charlie
Copy link

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-583

📔 Objective

Deprecate usage of Auth-Email Header

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details72825bf7-aeea-4936-964d-853bb5ab860a

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM SSL_Verification_Bypass /src/Core/Services/Implementations/MailKitSmtpMailDeliveryService.cs: 73
details/src/Core/Services/Implementations/MailKitSmtpMailDeliveryService.cs relies HTTPS requests, in SendEmailAsync. The ServerCertificateValidationCallb...
ID: %2BW1e%2BIF8kfVWMXgFu59dGPq6MAI%3D
Attack Vector
Fixed Issues (14)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationConfigurationController.cs: 19
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationConfigurationController.cs: 78
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationController.cs: 20
MEDIUM CSRF /src/Api/AdminConsole/Controllers/SlackIntegrationController.cs: 44
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationController.cs: 51
MEDIUM CSRF /src/Admin/Billing/Controllers/BusinessUnitConversionController.cs: 70
MEDIUM CSRF /src/Api/Billing/Controllers/AccountsController.cs: 142
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 97
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 97
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 96
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 86
MEDIUM SSL_Verification_Bypass /src/Core/Services/Implementations/MailKitSmtpMailDeliveryService.cs: 87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant