Support hex digits in OnePlus projid #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the deviceconfig keys have only 0-9 digits, however the format is actually hex, as evidenced by a handful of entries (for example: OP9 Pro TMO / "2085A").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the
deviceconfigkeys have only 0-9 digits, however the format is actually hex, as evidenced by a handful of entries, for example:edl/edlclient/Library/Modules/oneplus.py
Lines 115 to 116 in 8573eba
This change should fix the immediate error reported in: #237
(Even with this fix I'm having trouble getting writes to work for other reasons on the OnePlus 9 Pro, but I figure it make sense to fix the issues one at a time.)