Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TypeIDs the Primary Interface #103

Conversation

bkonkle
Copy link
Owner

@bkonkle bkonkle commented Jul 12, 2024

No description provided.

@bkonkle bkonkle changed the title [D-12] Make TypeIDs the Primary Interface Make TypeIDs the Primary Interface Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 30 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (fc0c1b1) to head (509d3d6).

Files Patch % Lines
nakago/src/inject/tag.rs 96.03% 4 Missing ⚠️
nakago_async_graphql/src/schema.rs 0.00% 4 Missing ⚠️
nakago_ws/src/controller.rs 0.00% 4 Missing ⚠️
nakago/src/inject/type_id.rs 97.82% 2 Missing ⚠️
nakago_axum/src/auth/jwks.rs 0.00% 2 Missing ⚠️
nakago_axum/src/routes.rs 0.00% 2 Missing ⚠️
nakago_sea_orm/src/connection.rs 0.00% 2 Missing ⚠️
nakago_warp/src/auth/jwks.rs 0.00% 2 Missing ⚠️
nakago_warp/src/routes.rs 0.00% 2 Missing ⚠️
nakago_axum/src/app.rs 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   63.43%   63.43%   -0.01%     
==========================================
  Files          51       51              
  Lines        3378     3386       +8     
==========================================
+ Hits         2143     2148       +5     
- Misses       1235     1238       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkonkle bkonkle merged commit 61766fa into main Jul 15, 2024
4 of 5 checks passed
@bkonkle bkonkle deleted the brandon/d-12-make-tags-secondary-to-cut-down-on-necessary-boilerplate branch July 15, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant