Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the fake dependency by moving away from git #126

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

bkonkle
Copy link
Owner

@bkonkle bkonkle commented Jan 7, 2025

Changed

  • (all packages) - Remove the git = "<https://github.com/cksac/fake-rs.git>" parameter from the fake dependency, as it is no longer needed.
  • nakago-axum - Change std::panic::PanicInfo to std::panic::PanicHookInfo

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.71%. Comparing base (bc2461f) to head (71a7b49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nakago_axum/src/init.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   61.38%   61.71%   +0.33%     
==========================================
  Files          47       47              
  Lines        3232     3221      -11     
==========================================
+ Hits         1984     1988       +4     
+ Misses       1248     1233      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkonkle bkonkle merged commit 5a693a4 into main Jan 7, 2025
5 of 6 checks passed
@bkonkle bkonkle deleted the bugfix/125-tutorial-missing-validator-dependency branch January 7, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant