IDETECT-4738: Make detect.binary.scan.file.name.patterns case insensitive

[shantyk]

Resolves IDETECT-4738

Scope of this PR is limited to detect.binary.scan.file.name.patterns, for which the official docs say:

By default, WildcardFileFilter is case sensitive. This was updated for this specific property only and all other uses of the test() method in the widely used file filter class have been left as is.

[andrian-sevastyanov]

Minor, but I feel like the original class name was more fitting. Now it's named CaseSensitive yet it can do both.

[shantyk]

I see what you mean... but the reason for changing it was the hope that this would prevent this class from being used without its default behaviour being clear in the future -- It is case sensitive by default but reason for IDETECT-4738 was because this was overlooked/assumed wrong at time of implementing detect.binary.scan.file.name.patterns.

[andrian-sevastyanov]

Now that I understand the intention I can offer a couple of options for your consideration:

• split this into 2 subclasses: DetectDirectoryFileFilterCaseSensitive and DetectDirectoryFileFilterCaseInsensitive, while having a parent abstract class contain most of the filtering
• make the constructor private and have the instantiation done by two different static methods: createCaseSensitiveFileFilter() and createCaseInsensitiveFIleFilter()

This is optional, especially since the PR is already merged.