Build process tweaks #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmc, thanks for the ideas and contribution! I just got back from some travel and checking it out now. |
blacktm
force-pushed
the
fix-build-process-and-instructions
branch
from
913726a to
043be51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
First off, thanks for your work on this, it's a pretty exciting idea to be able to use MRuby in browsers.
I did have a few issues getting started with it, especially when it was installed using
gem install, which doesn't checkout the mruby submodule. I did find the current instructions a bit confusing as to which parts of the building/using/examples instructions needed to happen in the gem dir vs. my own project dir, and was not able to get it to recompile with different gems.I also found it desirable to use a vendored version of mruby for each project, instead of having the gem provide it. This allows for different mruby-gems and build settings per-project.
I've made a few tweaks to allow using a vendored, easily-tweakable mruby install for each project, and updated the readme to reflect the instructions that got me started properly with it. Let me know how this looks, or if you'd like any changes made. Thanks again!