Upgrade to react 18 and added typescript #8
Conversation
| "eject": "node ../node_modules/react-scripts/bin/react-scripts.js eject", | ||
| "predeploy": "npm run build", | ||
| "deploy": "gh-pages -d build" | ||
| "start": "parcel index.html", |
There was a problem hiding this comment.
When I checked out this PR, running 'npm run start' under the example directory gives this error in the browser.
There was a problem hiding this comment.
When I checked out this PR, running 'npm run start' under the example directory gives this error in the browser.
I think the example just came with a template, It was not updated
| "test:watch": "react-scripts test --env=jsdom", | ||
| "predeploy": "cd example && npm install && npm run build", | ||
| "deploy": "gh-pages -d example/build" | ||
| "start": "tsdx watch", |
There was a problem hiding this comment.
Not sure why, but checking out this PR and installing dependencies with 'npm install --save', then 'npm run start' results in MODULE_NOT_FOUND
There was a problem hiding this comment.
Not sure why, but checking out this PR and installing dependencies with 'npm install --save', then 'npm run start' results in MODULE_NOT_FOUND
Not sure why, it is working fine for me
I didn't encounter any breaking changes; it was incompatible with the most recent version, which can be fixed with —legacy-peer-deps, but I just want to make it compatible with the most recent react and typescript projects. I'm still not sure if it's perfect because I'm still learning everything. |
|
would love to see this pr merged! |
No description provided.