Skip to content

Conversation

dsharp-pivotal
Copy link
Contributor

Hi @blang,

This PR adds support for the Symlink method to vfs. This is pretty straight forward on all Filesystem implementations except for MemFS, of course. In MemFS, it's probably still not a perfect analog of an OS filesystem, but I think it's a close enough start.

Thanks,
d#

CC: @goutamtadi1 @larham

Goutam Tadi and others added 2 commits September 17, 2018 10:12
In this commit, MemFS only supports absolute symlinks and can only open
them when the link is at the end of the path (no interior links).

Co-authored-by: Goutam Tadi <[email protected]>
Co-authored-by: David Sharp <[email protected]>
@dsharp-pivotal
Copy link
Contributor Author

Hi @blang Can you take a look at this PR? We've been using this code for a while now in our tests, and it is working without problem for us.

I fixed the gofmt issue Travis was reporting. The remaining failure looks like a config issue.

@karelbilek
Copy link

hmm this would be nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants