Remove dependency on jasypt#7
Open
dmacvicar wants to merge 2 commits intoblangel:masterfrom
dmacvicar:no_dependencies_1
Open
Remove dependency on jasypt#7dmacvicar wants to merge 2 commits intoblangel:masterfrom dmacvicar:no_dependencies_1
dmacvicar wants to merge 2 commits intoblangel:masterfrom
dmacvicar:no_dependencies_1
Conversation
We can use sun.misc.BASE64* as it is already used in net.ocheyedan.ply.dep.BasicAuth. In the future should look for a Apache licensed file and copy it into the tree as sun.misc.* is not public API.
Owner
|
@dmacvicar right. On my todo has always been revisiting the password compiled into code. Perhaps it should come from a configuration file. There would be a system one ($PLY_HOME/config/pwd.properties) which projects could override with their own project specific one (like any other ply property). Thoughts? |
Contributor
Author
|
It would be cool if we could interface with the native keyrings on Windows, Linux and OSX, however this may require a dependency on at least dbus bindings on Linux or using JNI (which I think you already pull somehow). |
Owner
|
Right, I think that a good idea (JNI is included currently for symlink as I created ply started prior to Java 7). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A build tool should is very low in the food chain and should have as little dependencies as possible.
Obfuscating password with fixed password encryption does not have much sense, but if it is going to be done, it is not worth to depend on an additional library for that.
This PR ports the obfuscation to sun.misc.BASE64_. We can use sun.misc.BASE64_ as it is already used in net.ocheyedan.ply.dep.BasicAuth. The PR also adds a previously non-existent test.
In the future should look for a Apache licensed file and copy it into the
tree as sun.misc.* is not public API.