WIP: Fix build with newer vala and libadwaita#358
WIP: Fix build with newer vala and libadwaita#358fortysixandtwo wants to merge 4 commits intobleakgrey:masterfrom
Conversation
The migration guide says: The can-swipe-back and can-swipe-forward properties have been renamed to AdwLeaflet:can-navigate-back and AdwLeaflet:can-navigate-forward, along with their accessors. The new properties also handle keyboard and mouse shortcuts in addition to swipes.
../src/Application.vala:46.49-52.3: error: value is less accessible than constant `Tootle.Application.app_entries'
46 | public const GLib.ActionEntry[] app_entries = {
| ^
47 | { "about", about_activated },
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
48 | { "compose", compose_activated },
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
49 | { "back", back_activated },
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
50 | { "refresh", refresh_activated },
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
51 | { "search", search_activated },
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
52 | };
| ~
…r valac) Vala started checking property names in https://gitlab.gnome.org/GNOME/vala/-/commit/38d61fbff037687ea4772e6df85c7e22a74b335e Resulting in the folowing example build failure: ../src/API/Status.vala:31.5-31.23: error: Name `_url' is not valid for a GLib.Object property 31 | public string? _url { get; set; } This commit removes leading underscores and makes other small adjustments to variable names.
From the migration guide: GtkButtonBox has been removed. Use a GtkBox instead.
|
FYI: some patches to use make 1.0 build with latest valac: (pretty much the same ones that are applied here) |
|
might be related as i am getting build errors: `lots more warnings..... ./src/API/Entity.vala:105.5-105.43: warning: unhandled error |
2 participants
This builds, but raises some criticals currently.
Just wanted to put it out there to avoid work duplication.
Fixes #337