Do not parse relation if it is 'null' #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
reviewed
Mar 20, 2017
| @@ -150,7 +150,9 @@ | |||
|
|
|||
| _.each(this.relations, function(rel, key) { | |||
| if (_.has(attrs, key)) { | |||
| attrs[key] = attrs[key].toJSON(); | |||
| if(attrs[key] !== null) { | |||
There was a problem hiding this comment.
@alexanderott thanks for the PR! I don't actively use this package anymore, so I don't know if this would be correct as you have done it, or would it be better to move the conditional up to the previous statement:
if (_.has(attrs, key) && attrs[key] !== null) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid parsing problem on an empty relation.