fix(penpal): fix CI release pipeline dry-run failures - #335
Merged
Conversation
loganj
changed the title
loganj
changed the title
The penpal-release.yml workflow relies on `go` being available via Hermit's activate step, but Go was never added as a Hermit package. This caused both matrix jobs to fail at the "Build Go sidecar" step with `go: command not found` (exit code 127). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tailwind CSS v4 moved the PostCSS plugin to a separate package. Update postcss.config.js to use @tailwindcss/postcss and remove autoprefixer (now handled internally by Tailwind v4). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
`pnpm run tauri:build -- --target <triple>` passes --target through to cargo via the `--` separator, so Tauri doesn't know the target triple. This causes the bundler to look in target/release/ instead of target/<triple>/release/, failing with "No such file or directory". Use `pnpm tauri build --target <triple>` instead so Tauri receives the flag directly and bundles from the correct output path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
loganj
force-pushed
the
fix/add-hermit-go
branch
from
March 3, 2026 02:01
5e1721a to
24bd328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dry-run of the
penpal-release.ymlworkflow (#322) revealed four build failures, plus one runtime bug. This PR fixes all of them:Add Go to Hermit — the workflow assumed
gowas available viaactivate-hermit, but Go was never added as a Hermit package. Both matrix jobs failed at "Build Go sidecar" withgo: command not found.Use
@tailwindcss/postcss— Tailwind CSS v4 moved the PostCSS plugin to a separate package. Updatedpostcss.config.jsand removed the now-unnecessaryautoprefixerdependency.Strip internal Artifactory URLs from lockfile —
pnpm addbakedglobal.block-artifacts.comtarball URLs intopnpm-lock.yaml(from~/.npmrc), which are unreachable from GitHub Actions macOS runners. Stripped the tarball URLs — pnpm only needs integrity hashes.Pass
--targetto Tauri CLI, not cargo —pnpm run tauri:build -- --target <triple>forwarded--targetto cargo via--, so Tauri didn't know the target triple and looked for the bundle in the wrong output directory. Changed topnpm tauri build --target <triple>.Null-safe file lists in review groups — server and UI code could crash when a review group had no files; added null guards throughout.
Test plan
pnpm install --frozen-lockfilepasses on macOS runnerspackage.shproduces zip artifactspushevent)🤖 Generated with Claude Code